Howdy, Stranger!

It looks like you're new here. If you want to get involved, click one of these buttons!

Key-up conditions not correctly detected in Any rule

thebitmasterthebitmaster Posts: 75PRO
edited December 2011 in Tech Support
If I create one Any Rule with several conditions, each of which is the detection of a Key Up event, the rule no longer fires after I add the second event. This would be correct for the All Rule, but not for the Any. If I create four separate rules for each separate key-up event, it works fine. They *should* be equivalent. Anyone know why they might not be?

I'm seeing this with 0.9.88 beta.


  • MotherHooseMotherHoose Posts: 2,456Member
    edited December 2011
    create the rule when Key Up; then nest the four separate rules

    computer constantly √s user input … it has done what you asked for with the first/second/third/fourth condition of the Any Rule …
    your second condition was true …
    Key state was up … condition was valid … performed that action … now waiting for another event to re-access those conditions.
    (i.e. Key is Down … waiting for Key to be Up : then √ the conditions again)

    alas, computers only do as directed, when directed; and don't repeat a direction unless told to do so by the program or user input.
  • I think we're not quite talking about the same thing. I probably shouldn't have said "second event" above. I meant "second condition", i.e. detection of the Release event for another, different arrow key.

    The project I submitted has all the details, but it's not visible here.

    Here's the simple case that works

    Any Rule
    - if key UP is released
    then stop moving

    This version works. However, if I have all four arrow keys in the decision list for the Any Rule, it *never* fires no matter how often any of those keys is released:

    Any Rule
    - if key UP is released
    - if key DOWN is released
    - if key RIGHT is released
    - if key LEFT is released
    then stop moving

    The actor never stops moving.

    If I make four completely separate rules like the first one above, then it works, but it shouldn't be necessary. The Any Rule with all four conditions should detect *any* of those conditions *whenever* it occurs, and fire.
  • MotherHooseMotherHoose Posts: 2,456Member
    think it is the same thing … computer doesn't recognize a change in the condition of the arrow keys … Up is the default for all keyboard keys

    think these rules should be part of the rules that initiate the event (movement)

    On your moving Actor:
    Group: Y axis
    when key Up is down
    changeAttribute [exp] self. Motion.linear velocity.Y To: 200 (the positive # for your speed)
    changeAttribute [exp] self. Motion.linear velocity.Y To: 0

    Rule: for Down key is virtually the same except the speed is - (negative)
    Group: X axis
    when key Right is down
    changeAttribute [exp] self. Motion.linear velocity.X To: 200 (the positive # for your speed)
    changeAttribute [exp] self. Motion.linear velocity.X To: 0

    Rule: for Left key is virtually the same except the speed is - (negative)
    it takes less time in to create these Rules in GS than for me to type them in this comment
    try to think of how the computers reads your directions …

  • Your solution here is more elegant than mine, and for that I thank you. I may chose to re-code my solution that way in the meantime.

    However, the fact that the simpler case in my second post above *does* work indicates that GS *does* detect both the transition from Up (understood to be the default) to Down, *and* from Down to Up, because that isolated rule that does nothing but detect the Key Up event fires correctly when there is only one condition to the rule. Add a second condition for another key, however, and with no other changes, the rule never fires again. It's the *why* of that truth that I'm trying to understand, and so far I haven't been able to glean an explanation from your otherwise helpful replies. It has something to do with the actually fairly complicated way that rule evaluation collides with keyboard input that isn't obvious from the docs. I *do* recall reading something, possibly in the update report of a new release, saying that with complex decision structures, if one value changes and the rule fires once, the other conditions might not be re-evaluated until the first value changes back again. Although it appears that the rule *never* fires in my case, it might be something similar going on here.

    Thanks for sticking with me on this one!
  • MotherHooseMotherHoose Posts: 2,456Member

    we tend to consider computers as thinking machines… when they are processing machines … think CPU!

    Computers are logical; literal; linear … all input is processed with the values of Boolean algebra …
    which you do understand adequately to program!
    binary: numerical notation has a base of 2 (i.e. only two #s: 0 and 1);
    0 and 1 are binary digits … i.e. bits
    that in words: 0 = false, no, or switch off, gate closed; and, 1 = true, yes, or switch on, gate open. <
    'Any' conditions structures are processed in linear flow (condition1; then condition2; then condition3; …)
    if condition1 is false (0; gate closed), the computer will process condition2.
    if a condition is true (1)… the gate is open and the computer will cease processing the conditions and move on to processing the actions/events you call for.

    re: "firing of rules" …
    my thoughts are: in your AnyRule, the computer does not process a default condition unless the state of the key has changed from the default.

    this functionality is not just in GS, but in all programming. (well, except in dynamic-programming, which none of us want to think about!)

  • I realize that one of GameSalad's best features is that it makes game programming easy for people with little previous programming experience, and that a lot of people who use it are a little light on their coding knowledge. It's probably worth mentioning, at this point, that I've been programming since the mid-1980s, and had coded professionally since the late 1990s. I've worked in embedded programming, software testing, and high level tech support for industrial engineers. I'm not using GS because it's the only way I can make a game, I use it because it's the fastest way to get a game to market, and also because I'm in love with the idea of democratizing game creation so one doesn't *have* to be a professional programmer to make games. It's safe to assume I understand all the basics of computer programming.

    It's also worth noting that there is a very simple reproducible case for this in the hands of tech support that saves a lot of this tedious "trying to describe in written language the nit-piggly details of a specific situation in GS".

    The issue is here related to the time-bound nature of GameSalad, and the real question is *when* is a previously evaluated Rule evaluated again? I *was* mistaken earlier when I said that the rule with the four conditions wasn't firing it all. As you stated, it *was* firing, by default, as soon as the program started to run. I verified this by changing the initial velocity of the actor to a non-zero value, and, sure enough, as soon as the game starts, the actor stops moving, meaning that rule fired one time.

    The real question here is "why is an identical rule with only one condition continuously re-evaluated when the same rule type of rule with multiple conditions isn't?"

    I have both actors on the screen at the same time. In the case of the one coded with all the key-up events in separate rules, the actor stops moving the instant one lets up on the keys. The same would be true, I'm guessing, of an actor using the method you suggested. It's also important to note that these rules are *not* inside a timer of any kind, I am counting on the GS engine to re-evaluate them as the events are received. This is the assumption that is breaking down in the case of the multiple-condition Any Rule in question. The actor that uses that Rule only stops once, as soon as the program is started, and never stops again, meaning that the rule is never evaluated again. So I decided to try putting that decision into a timer, and that "fixed" the problem. Putting it inside a timer evidently forces re-evaluation on every iteration, and the actor stops when I let go of the keys.

    A better way to narrow this discussion is to create an even simpler, completely unambiguous reproducible case without the need for an accompanying project, which is what I'm doing now.
  • thebitmasterthebitmaster Posts: 75PRO
    I've had a simplified version of this into GameSalad support since before Christmas, and while they've been letting me know they're still working on it, I haven't gotten a solution or a promise for a bugfix yet.
  • tenrdrmertenrdrmer Posts: 9,934Member, Sous Chef, Senior Sous-Chef
    edited January 2012
    I think the reason you are having an issue is adding a bunch of Key ups would mean the rule is almost always trigger and a condition is always met there for it does not continue to rule.

    For Example:
    "Any Rule
    - if key UP is released
    - if key DOWN is released
    - if key RIGHT is released
    - if key LEFT is released
    then stop moving"

    The only way this would work is for all the buttons to be down at all times then one is released. Once one is released the conditions are valid and the rule will not trigger again until all conditions become invalid again. I would recommend (and sorry if Motherhoose already covered this) Coding it like this.

    When Up is Down
    -Move Up
    ---When Down is Down
    ----Move Down
    ------When Right is Down
    -------Move Right
    ---------When Left is Down
    ----------Move Left
    ------------Stop Movement

    This will only allow one movement at a time and the way otherwises work it stops reading the rules below once a condition becomes valid. Then once invalid it goes back to checking for all of them.

    It's not my fault I never learned to take responsibility for anything. ;)

  • thebitmasterthebitmaster Posts: 75PRO

    Thanks for helping!
    So what you're saying is that the Any rule will not fire again until *all* of the rules are false again? I seemed to recall reading something like that, maybe in the release notes, and it's exactly what I was looking for. It seems like something GS support should have been able to tell me almost immediately. :) I'll look at the situation again in light of this info and see if that is, in fact the source of the problem.
  • tenrdrmertenrdrmer Posts: 9,934Member, Sous Chef, Senior Sous-Chef
    I dont know if that is how it is intended but thats how I see the logic of it. Rules only trigger again when they become inavlid first so if one of the any conditions are valid it will not trigger again until they all become invalid.

    It's not my fault I never learned to take responsibility for anything. ;)

  • thebitmasterthebitmaster Posts: 75PRO
    I also DLed Penguin Glide Lite. It was pretty fun! I got stuck on the 8th level in my first sitting.
This discussion has been closed.