adent42Key Master, Head Chef, Executive Chef, Member, PROPosts: 3,217
gs:rateApp is something we haven't fully tested, but we know we were close because of the debug logs. The problem was, it can only bet tested if the app is on the store (since it pulls up the Play Store apps rating widget).
adent42Key Master, Head Chef, Executive Chef, Member, PROPosts: 3,217
As for the other thing, I'm trying to finish up the iOS RC to allow people to release again. For those waiting on that we're running into a crash bug with pollfish. I have two more things to try and if that doesn't work, we'll release with the warning not to enable it.
adent42Key Master, Head Chef, Executive Chef, Member, PROPosts: 3,217
Current compile parameters on the RC are
SDK Version 31
minSDK 17
targetSDK 30
The main potential issue is we don't have a 17 device, so there MAY be occasional issues if the issues aren't caught by Google's compile time checks. But we haven't heard of any issues lately, so I think 17 should be fine and any problems tend to be device specific.
adent42Key Master, Head Chef, Executive Chef, Member, PROPosts: 3,217
So it's actually relatively easy for us to push that number up now if you (as the users), help with testing. The main time sink for SDK upgrades now that we've sorted out our build system is testing. So if it becomes imperative, let us know and we'll figure something out.
Great, thanks! I'm waiting on reply from them but it's a game without ads or any of the other complications, so hopefully it should be pretty easily tested.
Does gs:rateApp work for iOS and Android now? And you just put the "gs:rateApp" component in the message section of the Tweet Sheet right?
Cheersio
adent42Key Master, Head Chef, Executive Chef, Member, PROPosts: 3,217
@Hypnorabbit so for iOS I'm about 90% sure it works. The problem is, we can't fully test it in a unreleased app. But it seems to complain about the right thing in the error msg, so I think it works.
adent42Key Master, Head Chef, Executive Chef, Member, PROPosts: 3,217
Not yet, we're working on another project so I haven't been able to test the updated code yet. But go ahead and put the call for rating into your app for now and we should have something soon.
adent42Key Master, Head Chef, Executive Chef, Member, PROPosts: 3,217
FYI, updated RC with fixed ratings call will take a bit longer. I needed to update the build scripts and it turns out the new build system requires Java 11+, so I'll need to do some extra work installing two separate Javas to support both the old and new build systems for a while.
adent42Key Master, Head Chef, Executive Chef, Member, PROPosts: 3,217
So I tried patching in the code for android In-App Rating without the full upgrade and it compiles.
I haven't tested it yet, but feel free to give it a shot!
Instead of spending time testing it, we're gonna work on the upgrade to the build system to target API 31 with build tool 33 (which will allow us to target API 33 easier in the future). In addition we'll be doing the usual SDK upgrades, etc.
Afraid the gs:rateApp option doesn't seem to have worked in my last update of Sand. Possible I implemented it wrong, though! Does the gs:RrateApp need to be in the expression editor? I put it directly into the Message box. iOS.
adent42Key Master, Head Chef, Executive Chef, Member, PROPosts: 3,217
edited January 2023
So from what I can tell, iOS should be working fine, Android doesn't quite work. If you're seeing something different, share your project and I can take a look. The RC is addressing an issue with the Android / Google Play version version.
I pushed an update with the gs:Rate added, but tapping the button did nothing (while live on store). So in the next update I replaced it with a basic link again. Not sure what to share to be helpful here. I'll PM you the publishing link, though.
adent42Key Master, Head Chef, Executive Chef, Member, PROPosts: 3,217
Figured out the issue for iOS we think. You'll need sign your app with iOS App Signer to address this. Download the app and open Info.plist. Make sure the key 'GSAppleStoreId' is present and set as blank. That should fix the issue. New RC should ignore that key and all will be good.
Comments
gs:rateApp is something we haven't fully tested, but we know we were close because of the debug logs. The problem was, it can only bet tested if the app is on the store (since it pulls up the Play Store apps rating widget).
As for the other thing, I'm trying to finish up the iOS RC to allow people to release again. For those waiting on that we're running into a crash bug with pollfish. I have two more things to try and if that doesn't work, we'll release with the warning not to enable it.
Ok thank you @adent42 , hope you can get to those issues after the ios rc.
The ads getting played over and over is really a downer.
I appreciate the clear instructions for how to work-around this issue.
What is the current highest and lowest SDK supported for Android?
Contact me for custom work - Expert GS developer with 15 years of GS experience
Current compile parameters on the RC are
SDK Version 31
minSDK 17
targetSDK 30
The main potential issue is we don't have a 17 device, so there MAY be occasional issues if the issues aren't caught by Google's compile time checks. But we haven't heard of any issues lately, so I think 17 should be fine and any problems tend to be device specific.
Thanks. The publisher we're talking to is requiring 32 but I'm asking how firm a requirement that is.
Contact me for custom work - Expert GS developer with 15 years of GS experience
So it's actually relatively easy for us to push that number up now if you (as the users), help with testing. The main time sink for SDK upgrades now that we've sorted out our build system is testing. So if it becomes imperative, let us know and we'll figure something out.
Great, thanks! I'm waiting on reply from them but it's a game without ads or any of the other complications, so hopefully it should be pretty easily tested.
Contact me for custom work - Expert GS developer with 15 years of GS experience
Random necro of the century:
Does gs:rateApp work for iOS and Android now? And you just put the "gs:rateApp" component in the message section of the Tweet Sheet right?
Cheersio
@Hypnorabbit so for iOS I'm about 90% sure it works. The problem is, we can't fully test it in a unreleased app. But it seems to complain about the right thing in the error msg, so I think it works.
I can confirm that it works on IOS, I couldn't get it to work on Android
Thanks legends - did you have a workaround for Android @zarzir or what was the problem?
I don't have a workaround, It just didn't work, nothing happened when calling the rule (only test on my pixel 4)
So I took a look at the code and found a slight problem with it, gonna test it tonight and deploy if it works.
That sounds great - if you can confirm it works I'll use it in my Android app.
Does Google Play rating work on Android? @adent42
Not yet, we're working on another project so I haven't been able to test the updated code yet. But go ahead and put the call for rating into your app for now and we should have something soon.
FYI, updated RC with fixed ratings call will take a bit longer. I needed to update the build scripts and it turns out the new build system requires Java 11+, so I'll need to do some extra work installing two separate Javas to support both the old and new build systems for a while.
So I tried patching in the code for android In-App Rating without the full upgrade and it compiles.
I haven't tested it yet, but feel free to give it a shot!
Instead of spending time testing it, we're gonna work on the upgrade to the build system to target API 31 with build tool 33 (which will allow us to target API 33 easier in the future). In addition we'll be doing the usual SDK upgrades, etc.
Afraid the gs:rateApp option doesn't seem to have worked in my last update of Sand. Possible I implemented it wrong, though! Does the gs:RrateApp need to be in the expression editor? I put it directly into the Message box. iOS.
Contact me for custom work - Expert GS developer with 15 years of GS experience
directly is good. if it’s an expression, it would need to be in quotes. from what i can tell, it should work on iOS, but not Android
The upcoming RC should fix it
Which does this refer to? Thanks!
Contact me for custom work - Expert GS developer with 15 years of GS experience
gs:rateApp
I meant iOS or Android or both :D Still not certain if I just implemented it wrong or if it didn't work.
Contact me for custom work - Expert GS developer with 15 years of GS experience
So from what I can tell, iOS should be working fine, Android doesn't quite work. If you're seeing something different, share your project and I can take a look. The RC is addressing an issue with the Android / Google Play version version.
I pushed an update with the gs:Rate added, but tapping the button did nothing (while live on store). So in the next update I replaced it with a basic link again. Not sure what to share to be helpful here. I'll PM you the publishing link, though.
Contact me for custom work - Expert GS developer with 15 years of GS experience
Figured out the issue for iOS we think. You'll need sign your app with iOS App Signer to address this. Download the app and open Info.plist. Make sure the key 'GSAppleStoreId' is present and set as blank. That should fix the issue. New RC should ignore that key and all will be good.